Skip to content

Commit

Permalink
object: fix the limiting interface of object storage (#5239)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhijian-pro authored and jiefenghuang committed Nov 26, 2024
1 parent 695ac3a commit 78f8883
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
3 changes: 3 additions & 0 deletions pkg/object/ibmcos.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ func (s *ibmcos) Create() error {
func (s *ibmcos) Limits() Limits {
return Limits{
IsSupportMultipartUpload: true,
MinPartSize: 5 << 20,
MaxPartSize: 5 << 30,
MaxPartCount: 10000,
}
}

Expand Down
3 changes: 3 additions & 0 deletions pkg/object/oos.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ func (s *oos) String() string {
func (s *oos) Limits() Limits {
return Limits{
IsSupportMultipartUpload: true,
MinPartSize: 5 << 20,
MaxPartSize: 5 << 30,
MaxPartCount: 10000,
}
}

Expand Down
3 changes: 3 additions & 0 deletions pkg/object/scs.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ func (s *scsClient) String() string {
func (s *scsClient) Limits() Limits {
return Limits{
IsSupportMultipartUpload: true,
MinPartSize: 5 << 20,
MaxPartSize: 5 << 30, // guess
MaxPartCount: 2048,
}
}

Expand Down
4 changes: 1 addition & 3 deletions pkg/object/space.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ func (s *space) String() string {
}

func (s *space) Limits() Limits {
return Limits{
IsSupportMultipartUpload: true,
}
return s.s3client.Limits()
}

func newSpace(endpoint, accessKey, secretKey, token string) (ObjectStorage, error) {
Expand Down

0 comments on commit 78f8883

Please sign in to comment.