meta/memkv: fix the conflict between scan and write operations (#3838)

juicedata · Jun 20, 2023 · 5aea39c · 5aea39c
1 parent 4867ec4
commit 5aea39c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/pkg/meta/tkv_mem.go b/pkg/meta/tkv_mem.go
@@ -236,17 +236,16 @@ func (c *memKV) txn(f func(*kvTxn) error, retry int) error {
 
 func (c *memKV) scan(prefix []byte, handler func(key []byte, value []byte)) error {
 	c.Lock()
-	defer c.Unlock()
+	snap := c.items.Clone()
+	c.Unlock()
 	begin := string(prefix)
 	end := string(nextKey(prefix))
-	c.items.AscendGreaterOrEqual(&kvItem{key: begin}, func(i btree.Item) bool {
+	snap.AscendGreaterOrEqual(&kvItem{key: begin}, func(i btree.Item) bool {
 		it := i.(*kvItem)
 		if end != "" && it.key >= end {
 			return false
 		}
-		c.Unlock()
 		handler([]byte(it.key), it.value)
-		c.Lock()
 		return true
 	})
 	return nil