Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bioimageio model export #137

Merged
merged 7 commits into from
Jun 11, 2023
Merged

Update bioimageio model export #137

merged 7 commits into from
Jun 11, 2023

Conversation

veegalinova
Copy link
Contributor

  • add code from napari-n2v for bioimageio model export
  • check and fix notebook examples
  • add bioimageio.core dependency

@jdeschamps
Copy link
Member

Awesome!

The CI doesn't pass because of the windowspwd problem... I never had the time to look at that, so I am not sure if there is an "easy" fix that could be pushed to the bioimage core. Something to ask Fynn probably. Maybe ask around at the hackathon if anyone knows?

In napari-n2v, I simply skip the bioimage.io related tests in the CI.

@veegalinova
Copy link
Contributor Author

veegalinova commented Jun 8, 2023

Quick googling showed that this is caused by a bug in python standard library, funny stuff...
thonny/thonny#1146, https://bugs.python.org/issue32731

For now, I will skip the test in the CI the same way as in napari-n2v. And I will also raise an issue in the bioimage repository.

@jdeschamps jdeschamps merged commit db225e3 into main Jun 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants