Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports from build/src #143

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Fix imports from build/src #143

merged 2 commits into from
Dec 30, 2022

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented Dec 27, 2022

These imports directly import the CommonJS version instead of selecting via the package definition.

In angular these produce warnings about CommonJS packages.

These imports directly import the CommonJS version instead of via the package definition.

In angular these produce warnings about CommonJS packages.
@kdubb
Copy link
Contributor Author

kdubb commented Dec 27, 2022

NoopTextMapPropagator is not explicitly exported so it was switch to esm considering this is specifically for Angular 13+.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #143 (279ad0e) into main (f0e6627) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          332       335    +3     
  Branches        61        61           
=========================================
+ Hits           332       335    +3     
Impacted Files Coverage Δ
...vices/exporter/otelcol/otelcol-exporter.service.ts 100.00% <100.00%> (ø)
...ext-propagator/noop-text-map-propagator.service.ts 100.00% <100.00%> (ø)
...ojects/opentelemetry-interceptor/src/public-api.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jufab
Copy link
Owner

jufab commented Dec 30, 2022

Hi @kdubb

Thanks for your contribution.

I just did a commit to fix unit test and remove NoopTextMapPropagator : return a null value have the same effect.

@jufab jufab merged commit 7f3aba9 into jufab:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants