Exposing Exporter services for custom usage. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 332 336 +4
Branches 61 61
=========================================
+ Hits 332 336 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporting additional exporter services to be used for bootstrapping outside of the usual module flow.
Since we use async configuration retrieval, we can't offer the configurations to an imported module (ie
OpenTelemetryInterceptorModule.forRoot(environment.opentelemetryConfig)).We have to use a slightly different flow which directly creates a
OpenTelemetryHttpInterceptor. Even if theOpenTelemetryHttpInterceptoris given configurations, the ZipkinExporterService does not use the provided configurations so we have to create the service ourselves with our resolved configurations.