Skip to content

Commit

Permalink
fix: SSO integration not considering HTTP_PROXY when making requests. F…
Browse files Browse the repository at this point in the history
…ixes argoproj#9259 (argoproj#9760)

fix: SSO integration not considering HTTP_PROXY env vars when making requests

Signed-off-by: Rohan Kumar <[email protected]>

Signed-off-by: Rohan Kumar <[email protected]>
Signed-off-by: juchao <[email protected]>
  • Loading branch information
rohankmr414 authored and juchaosong committed Nov 3, 2022
1 parent 00f5a49 commit f77c536
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion server/auth/sso/sso.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ type providerInterface interface {
type providerFactory func(ctx context.Context, issuer string) (providerInterface, error)

func providerFactoryOIDC(ctx context.Context, issuer string) (providerInterface, error) {
return oidc.NewProvider(ctx, issuer)
oidcCtx := oidc.ClientContext(ctx, &http.Client{})
return oidc.NewProvider(oidcCtx, issuer)
}

func New(c Config, secretsIf corev1.SecretInterface, baseHRef string, secure bool) (Interface, error) {
Expand Down

0 comments on commit f77c536

Please sign in to comment.