Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I discovered cwe-416 vulnerabilities in the project. #1325

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,10 @@ class LinuxModule : public Module
if (!filesystem::is_directory (modulePath))
return {};

stem.replace_extension (".so");
modulePath /= stem;
auto newStem = stem;
newStem.replace_extension(".so");
modulePath /= newStem;

return Optional<Path> (std::move (modulePath));
}

Expand Down Expand Up @@ -323,11 +325,13 @@ Module::SnapshotList Module::getSnapshots (const std::string& modulePath)
{
filesystem::path p (png);
auto filename = p.filename ().generic_string ();
auto uid = Snapshot::decodeUID (filename);
auto uid = Snapshot::decodeUID(filename);


if (!uid)
continue;
auto scaleFactor = 1.;
if (auto decodedScaleFactor = Snapshot::decodeScaleFactor (filename))
if (auto decodedScaleFactor = Snapshot::decodeScaleFactor(filename))
scaleFactor = *decodedScaleFactor;

Module::Snapshot::ImageDesc desc;
Expand Down Expand Up @@ -366,4 +370,4 @@ Optional<std::string> Module::getModuleInfoPath (const std::string& modulePath)

//------------------------------------------------------------------------
} // Hosting
} // VST3
} // VST3
Loading