Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modals cancelled when app is minimised #1316

Closed
wants to merge 1 commit into from

Conversation

quickiwiki
Copy link

This PR resolves issue #1315

@stephenk-az
Copy link

This was the same fix I suggested here (essentially) and attila provided a good reason why this would NOT be the best fix:

https://forum.juce.com/t/bug-minimize-to-dock-on-macos-causes-modal-component-to-lose-modality/57974/5

"The suggested workaround could break existing use-cases. In an application with multiple windows, minimising the one with the modal component would leave the visible window in a non-interactive state, and it would be difficult to discover why this is the case."

@szarvas
Copy link
Member

szarvas commented Jan 18, 2024

A change has been released on develop

fb14118

The minimise and close buttons are now disabled when a component is modal, to avoid this problem the same way Windows does.

@szarvas szarvas closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants