Crash fix: Remove Concertina header mouse listener on destroy #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash bug where the header component (provided that it was owned by the caller, i.e. shouldTakeOwnership=false) has a dangling mouse listener pointing to "this," which is a PanelHolder that has been destroyed. We need to remove this listener when either the PanelHolder is destroyed, or a new custom header has been set. Otherwise, if that custom header is used again, mousing over it will SIGSEGv.
|
Woohoo, thanks, @reuk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash bug where the header component (provided that it was owned by the caller, i.e. shouldTakeOwnership=false) has a dangling mouse listener pointing to "this," which is a PanelHolder that has been destroyed. We need to remove this listener when either the PanelHolder is destroyed, or a new custom header has been set. Otherwise, if that custom header is used again, mousing over it will SIGSEGV when the mouse listener is invoked.