Switch to a structured logger #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
juanfont
reviewed
Aug 5, 2021
| @@ -17,7 +18,7 @@ var rootCmd = &cobra.Command{ | |||
| headscale is an open source implementation of the Tailscale control server | |||
|
|
|||
| Juan Font Alonso <[email protected]> - 2021 | |||
| https://gitlab.com/juanfont/headscale`, | |||
| https://github.com/juanfont/headscale`, | |||
juanfont
reviewed
Aug 5, 2021
| log.Debug(). | ||
| Str("handler", "Registration"). | ||
| Str("machine", m.Name). | ||
| Msg("Client is registered and we have the current NodeKey. All clear to /mSending keepaliveap") |
There was a problem hiding this comment.
All clear to /mSending keepaliveap
All clear to /map
juanfont
requested changes
Aug 5, 2021
|
Actually, #75 is too important. Going to merge this immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from the built in Go logger to a structured logger (zerolog).
This allows us to:
Please note, this does not change or override Gin's logger, only the internal one.
example:
