Skip to content

poll: fix swapped machine<->namespace labels #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2022
Merged

poll: fix swapped machine<->namespace labels #312

merged 3 commits into from
Feb 12, 2022

Conversation

hdhoang
Copy link
Contributor

@hdhoang hdhoang commented Feb 11, 2022

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Hi, we noticed label mismatches in update_request_* metrics:

# correct
headscale_last_update_seconds{machine="router1",namespace="routers"} 1.644561297e+09
headscale_last_update_seconds{machine="router2",namespace="routers"} 1.644561296e+09

# swapped labels
headscale_update_request_from_node_total{machine="routers",namespace="router1",state="endpoint-update"} 47
headscale_update_request_from_node_total{machine="routers",namespace="router1",state="full-update"} 26
headscale_update_request_from_node_total{machine="routers",namespace="router1",state="scheduled-update"} 1096
headscale_update_request_from_node_total{machine="routers",namespace="router2",state="endpoint-update"} 4
headscale_update_request_from_node_total{machine="routers",namespace="router2",state="full-update"} 2
headscale_update_request_from_node_total{machine="routers",namespace="router2",state="scheduled-update"} 1058

Hope this helps!

@kradalby kradalby merged commit c794f32 into juanfont:main Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants