Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for titles and commands #113

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Add icons for titles and commands #113

merged 1 commit into from
Mar 29, 2023

Conversation

bollwyvl
Copy link
Contributor

Thanks for ipylab!

Changes:

  • adds a new Icon which takes an svgstr
    • can be given to both Panel.title and add_command(icon=).
    • inherits from DOMWidget with an actual View so that it can be used out of these contexts as well...
      • it is a little funky because of how it expects to work inside react, but is fast enough
    • adds a notebook with some links from other notebooks
  • improves the jlpm watch command to also build the labextension
  • delays loading the widgets implementations and dependencies until they are requested

Open questions:

  • would it be better to call it LabIcon for searchability?
  • what to do about closable sidebars?
    • the x icon "wins"

@github-actions
Copy link
Contributor

Binder 👈 Try it on Binder (branch bollwyvl/ipylab/add-labicon)

@jtpio jtpio added the enhancement New feature or request label Mar 29, 2023
Copy link
Owner

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit a281d95 into jtpio:main Mar 29, 2023
@bollwyvl
Copy link
Contributor Author

I'll think about some alternatives for the sidebar: maybe it's "just a thing you have to do," as in

  • make the Panel not closable
  • offer some other way to close it on a panel, or from somewhere else

@jtpio
Copy link
Owner

jtpio commented Mar 29, 2023

This should now be available in 0.7.0: https://github.com/jtpio/ipylab/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants