Add to missing-phase-hooks explanation#40
Merged
jtojnar merged 1 commit intojtojnar:masterfrom Feb 12, 2021
Merged
Conversation
jtojnar
reviewed
Feb 12, 2021
rmcgibbo
force-pushed
the
missing-phase-hooks
branch
from
24a3c14 to
363f5d4
Compare
jtojnar
force-pushed
the
missing-phase-hooks
branch
from
363f5d4 to
1983acc
Compare
Owner
|
Thanks. |
Collaborator
Author
|
Hey, you did all the work :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandro explained this here: NixOS/nixpkgs#112897 (comment), and I hadn't actually realized why this check was so important until he said it.