Necessary patches for running rtree on real machines #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingnus
commented
Oct 27, 2023
mingnus
commented
- Fix data block ref counts while overwriting: Allow updating the timestamp without remapping data blocks.
- Make rtree an optional feature to dm-thin via table flags, and parameterize the interface to rtree and btree.
- Complete missing features: dm_rtree_lookup_next, dm_rtree_find_highest_key
- Bug fixes: nr_mapped_blocks in details tree; double free on extent allocator.
Decrease the data block if the overwrite remaps the data block; otherwise update the timestamp only.
Now that we use a callback for the final allocation from the extent we have to cope with calls that sleep.
The internal nodes should be reclaimed while destroying the tree. Otherwise, the allocator won't be able to allocate leaves for all the contexts after resetting, ends up with shared extents.
mingnus
force-pushed
the
2023-09-27-rtree-metadata-format
branch
from
897f61c to
5f58bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.