Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Sync with [email protected] based on (PR #194 & #200) #201

Merged
merged 11 commits into from
Jan 17, 2023

Conversation

pham
Copy link
Contributor

@pham pham commented Jan 16, 2023

Summary

  • Fix missing 2nd arg for Server.respond() causing TypeError (see error dump below)
  • Add prerendered files to public dir (thanks @AndrewLester)
  • Add Node.js 18 support

Fixes: #194 #200

TypeError

⚠  functions: TypeError: Cannot read properties of undefined (reading 'prerendering')
    at respond (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31409:14)
    at Server.respond (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31705:12)
    at svelteKit (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31767:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runFunction (/tmp/svelte-adapter-firebase-wxGf/node_modules/firebase-

@pham
Copy link
Contributor Author

pham commented Jan 16, 2023

I ripped out the Node.js 18 check stuff from the merge (I didn't realize @jthegedus already removed them).

@pham
Copy link
Contributor Author

pham commented Jan 16, 2023

Updated end-to-end test.

@jthegedus
Copy link
Owner

@pham You're a legend. You have come and saved me from the impending doom of updating this repo 🙏

Copy link
Owner

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @pham

@jthegedus jthegedus changed the title fix: Sync with [email protected] based on (PR #194 & #200) chore!: Sync with [email protected] based on (PR #194 & #200) Jan 17, 2023
@jthegedus jthegedus merged commit e933b92 into jthegedus:sync-kit-alpha-587 Jan 17, 2023
@jthegedus
Copy link
Owner

jthegedus commented Jan 17, 2023

I thought the ! would mean release-please would identify this as a breaking change and include in it's Release. Apparently chore takes precedent. Annoying! I'll try and fix this.

jthegedus added a commit that referenced this pull request Jan 17, 2023
@jthegedus jthegedus changed the title chore!: Sync with [email protected] based on (PR #194 & #200) fix!: Sync with [email protected] based on (PR #194 & #200) Jan 17, 2023
jthegedus added a commit that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants