Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Acquiring location" goes forever, breaks app #50

Closed
makbol opened this issue Oct 28, 2021 · 12 comments
Closed

"Acquiring location" goes forever, breaks app #50

makbol opened this issue Oct 28, 2021 · 12 comments
Labels

Comments

@makbol
Copy link

makbol commented Oct 28, 2021

Sometimes it's able to acquire location, sometimes not and I can't use app. Maybe instead of automatic location, allow user to manually input sensor via settings?

I'd to help but local development guide is missing :(. Not sure what I need to be fully able to locally develop.

@lukas085
Copy link

lukas085 commented Dec 7, 2021

I have the same problem.

@RudolfTheOne
Copy link

same, unable to get the location on 3 devices :/

@makbol
Copy link
Author

makbol commented Jan 7, 2022

@lukas085 @RudolfTheOne @mszymczak-silvair check out my fix :)

@RudolfTheOne
Copy link

Wow, you are a real savior, thank you @makbol!
@jsynowiec will you release the new version soon?

@jsynowiec
Copy link
Owner

I am unable to reproduce this issue. Can you provide more details?

@RudolfTheOne
Copy link

This is what I see (since ~Dec 2021) - it keeps acquiring location forever.

Screenshot 2022-01-10 at 11 17 06

@jsynowiec
Copy link
Owner

Thanks, I have found what the issue is. I could not reproduce it because I am using a different Google API key than the one included in the binaries. The account I was using to sustain the open-source free release ran out of credits in 2021, so it will not work anymore because the Geolocation API is not a free service. Also, the DigitalOcean's account, which hosts the Airqmon API droplet, will run out of credits in March, and the API will stop functioning.

For transparency, the monthly costs for Airqmon were about 50$, and I am no longer willing to cover that. I covered a lot since November 2017 out of my pocket, while the only received support was from the @digitalocean open-source program and one-time donations from @thymikee and @kdzwinel. I could offset some using the free credits until now, but that's no longer an option 🤷🏼‍♂️

I have removed all binaries from the current and previous releases as they will no longer work. You can clone the latest release and build your own version while providing a working Google API key. The Airqmon API will keep functioning for a month or two more.

@thymikee
Copy link

Sad to hear it, but I totally feel you @jsynowiec. Thanks for all the time and support you provided and for keeping the app in the open. Appreciated <3

jsynowiec added a commit that referenced this issue Jan 10, 2022
Mitigates #50 through replacing the Google Geolocation API with a free ip-api.com. The acquired location will have a lower accuracy because the SSID-based geolocation is now removed.
@jsynowiec
Copy link
Owner

I found a free geolocation service that does not require a key. Please check the v2.1.1 release. I will remove the pre-release flag if it works for you.

@makbol
Copy link
Author

makbol commented Jan 10, 2022

Thanks for providing context. As you mentioned, even if you fix the geolocation error there's still API service which will run out of founds in March so changing location service will not fix that issue or maybe just temporarily.

Regarding new geolocation service - I tried and I'm getting an error - "communication error". I inspected that and it seems it's and Airqmon API issue now. The location was fetched successfully.

Zrzut ekranu 2022-01-10 o 15 29 57

@jsynowiec
Copy link
Owner

@makbol, I would say that this is an issue with the data returned from Airly. I used your IP address and location to check the response, and you can see the same sensor station on the screenshot.

image

I have seen in logs that some sensor stations can disappear or return incorrect data even if the station shows correctly on Airly's map 🤷🏼‍♂️

As you mentioned, even if you fix the geolocation error there's still API service which will run out of founds in March so changing location service will not fix that issue or maybe just temporarily.

Well, it turned out that there was no error to start with 😉 The geolocation code in 2.1.0 works just fine. There is a different kind of issue, but I explained that in my previous comment.

With the latest commits, I just tried to provide an alternative to those who cannot or do not want to pay for the Google API 😄 We will see what happens regarding the API. There are still a few months of credits left.

@makbol
Copy link
Author

makbol commented Jan 12, 2022

I meant, the issue with geolocation :). Looks like, with new location API it's working fine now although I'm getting station which is not close to my real location. How about introducing manual mode (as an option for more advanced users) which would enable manually picking station?

btw. can you please remove my ip address from screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants