detect used props in jsx #946
Conversation
| @@ -347,12 +347,13 @@ function componentRule(rule, context) { | |||
| var isFunction = /Function/.test(node.type); // Functions | |||
| var isMethod = node.parent && node.parent.type === 'MethodDefinition'; // Classes methods | |||
| var isArgument = node.parent && node.parent.type === 'CallExpression'; // Arguments (callback, etc.) | |||
| var isJSX = node.parent && node.parent.type === 'JSXExpressionContainer'; | |||
| // Stop moving up if we reach a class or an argument (like a callback) | |||
| if (isClass || isArgument) { | |||
| return null; | |||
| } | |||
| // Return the node if it is a function that is not a class method | |||
There was a problem hiding this comment.
This comment should probably be updated.
| @@ -347,12 +347,13 @@ function componentRule(rule, context) { | |||
| var isFunction = /Function/.test(node.type); // Functions | |||
| var isMethod = node.parent && node.parent.type === 'MethodDefinition'; // Classes methods | |||
| var isArgument = node.parent && node.parent.type === 'CallExpression'; // Arguments (callback, etc.) | |||
| var isJSX = node.parent && node.parent.type === 'JSXExpressionContainer'; | |||
There was a problem hiding this comment.
I might be misunderstanding what this is checking for here, but I'm not sure this variable name makes sense. I think isJSXExpressionContainerExpression would be more accurate.
Additionally, it might be nice to include a comment with an example of what type of code this identifies.
There was a problem hiding this comment.
Also, does this bug exist for folks not using JSX? (i.e. React.createElement)
React.createElement("a", { onClick: function onClick() {
return props.previousPage();
} });There was a problem hiding this comment.
The problem is that functions inside a JSXExpressionContainer are bing mistaken for stateless components.
For example: <button onClick={() => props.handleClick()}></button>
where {() => props.handleClick()} is theJSXExpressionContainer
fixes #885