Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react-in-jsx-scope rule #5

Merged
merged 1 commit into from
Mar 1, 2015

Conversation

glenjamin
Copy link
Contributor

Hope this makes sense - I've included tests & docs as well.

See eslint/eslint#1905 for some additional context.

I'm planning to follow up with a variant on no-unused that knows about JSX using React.createElement.

Sidenote: should there be a test which verifies all rules are exported in index.js ?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.92%) to 98.08% when pulling de17bfe on glenjamin:react-in-jsx-scope into 9c43de0 on yannickcr:master.

@glenjamin
Copy link
Contributor Author

Whoops, missed a test case for nested scopes - will add one to bump the coverage back up.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5fec402 on glenjamin:react-in-jsx-scope into 9c43de0 on yannickcr:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5fec402 on glenjamin:react-in-jsx-scope into 9c43de0 on yannickcr:master.

@yannickcr
Copy link
Member

Thanks for contributing! Looks good to me.

should there be a test which verifies all rules are exported in index.js ?

There is not, but i should definitely add one.

yannickcr added a commit that referenced this pull request Mar 1, 2015
@yannickcr yannickcr merged commit d2480bc into jsx-eslint:master Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants