Default display-name's acceptTranspilerName to true #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a change that has been queued for v4. Addresses jsx-eslint#436
| @@ -14,7 +14,9 @@ module.exports = Components.detect(function(context, components, utils) { | |||
|
|
|||
| var sourceCode = context.getSourceCode(); | |||
| var config = context.options[0] || {}; | |||
| var acceptTranspilerName = config.acceptTranspilerName || false; | |||
| var acceptTranspilerName = config.hasOwnProperty('acceptTranspilerName') ? | |||
There was a problem hiding this comment.
instead of making "absence" and "falsy" be different, would it be better as a breaking change to rename the option to something like "ignoreTranspilerName"?
There was a problem hiding this comment.
Yeah, I definitely like that better--I was just doing what @yannickcr had written in the plan. I'm going to be afk for the next few days starting soon, so I'll push another version and he can choose his favorite.
There was a problem hiding this comment.
New version is at #440
|
Merged #440 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a change that has been queued for v4.
Addresses #436