Fix ESLint v10 RuleContext API removal (follow-up to #3972)

.github/workflows/node-18+.yml

@@ -26,6 +26,7 @@ jobs:
       matrix:
         node-version: ${{ fromJson(needs.matrix.outputs.latest) }}
         eslint:
+          - 10
           - 9
           - 8
           - 7
@@ -44,6 +45,13 @@ jobs:
           - 7
           - 8
         exclude:
+          # ESLint 10 supports Node.js 20+.
+          - eslint: 10
+            node-version: 18
+          - eslint: 10
+            node-version: 19
+          - eslint: 10
+            babel-eslint: 8
           - eslint: 3
             babel-eslint: 10
           - eslint: 3
@@ -104,7 +112,7 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
           after_install: |
-            npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.typescript-eslint == 8 && 8.17 || matrix.typescript-eslint }}" "babel-eslint@${{ matrix.babel-eslint }}"
+            npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || (matrix.typescript-eslint == 8 && '8.17' || matrix.typescript-eslint) }}" "babel-eslint@${{ matrix.babel-eslint }}"
         env:
           NPM_CONFIG_LEGACY_PEER_DEPS: "${{ matrix.typescript-eslint >= 6 && 'false' || 'true' }}"
       - run: npx ls-engines

.github/workflows/type-check.yml

@@ -7,11 +7,14 @@ permissions:
 
 jobs:
   test:
-    name: TS ${{ matrix.ts_version }}, "${{ matrix.ts_lib }}"
+    name: ESLint ${{ matrix.eslint_version }}, TS ${{ matrix.ts_version }}, "${{ matrix.ts_lib }}"
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
+        eslint_version:
+          - '7'
+          - '10'
         ts_version:
           # The official ESLint types are not compatible with TS 3.9
           # - 3.9
@@ -29,6 +32,20 @@ jobs:
           - es2015,dom
           - es2020
           - esnext
+        exclude:
+          # ESLint 10 jobs are only run with TS >= 5.0.
+          - eslint_version: '10'
+            ts_version: '4.0'
+          - eslint_version: '10'
+            ts_version: 4.1
+          - eslint_version: '10'
+            ts_version: 4.2
+          - eslint_version: '10'
+            ts_version: 4.3
+          - eslint_version: '10'
+            ts_version: 4.4
+          - eslint_version: '10'
+            ts_version: 4.5
     steps:
       - uses: actions/checkout@v4
         with:
@@ -41,6 +58,17 @@ jobs:
           node-version: 'lts/*'
           skip-ls-check: true
 
+      - name: select eslint types
+        run: |
+          if [ "${{ matrix.eslint_version }}" = "10" ]; then
+            # Avoid dev dependency peer conflicts with eslint@10.
+            npm prune --omit=dev
+            npm uninstall --no-save @types/eslint
+            npm install --no-save --legacy-peer-deps eslint@^10 typescript@^5
+          else
+            npm install --no-save eslint@^7 @types/eslint@7.2.10
+          fi
+
       - name: build types
         run: npm run build-types
 
@@ -60,6 +88,15 @@ jobs:
         run: npm install
         working-directory: test-published-types
 
+      - name: select eslint for published types
+        run: |
+          if [ "${{ matrix.eslint_version }}" = "10" ]; then
+            npm install --no-save eslint@^10
+          else
+            npm install --no-save eslint@^7
+          fi
+        working-directory: test-published-types
+
       - name: install eslint-plugin-react and typescript version ${{ matrix.ts_version }}
         run: npm install --no-save "$ESLINT_PLUGIN_REACT_PATH" typescript@${{ matrix.ts_version }}
         working-directory: test-published-types

lib/rules/forward-ref-uses-ref.js

@@ -6,6 +6,7 @@
 
 const isParenthesized = require('../util/ast').isParenthesized;
 const docsUrl = require('../util/docsUrl');
+const getSourceCode = require('../util/eslint').getSourceCode;
 const report = require('../util/report');
 const getMessageData = require('../util/message');
 
@@ -57,7 +58,7 @@ module.exports = {
   },
 
   create(context) {
-    const sourceCode = context.getSourceCode();
+    const sourceCode = getSourceCode(context);
 
     return {
       'FunctionExpression, ArrowFunctionExpression'(node) {

lib/rules/jsx-filename-extension.js

@@ -7,6 +7,7 @@
 
 const path = require('path');
 const docsUrl = require('../util/docsUrl');
+const getFilename = require('../util/eslint').getFilename;
 const report = require('../util/report');
 
 // ------------------------------------------------------------------------------
@@ -61,7 +62,7 @@ module.exports = {
   },
 
   create(context) {
-    const filename = context.getFilename();
+    const filename = getFilename(context);
 
     let jsxNode;
 

lib/util/eslint.js

@@ -4,6 +4,10 @@ function getSourceCode(context) {
   return context.getSourceCode ? context.getSourceCode() : context.sourceCode;
 }
 
+function getFilename(context) {
+  return context.getFilename ? context.getFilename() : context.filename;
+}
+
 function getAncestors(context, node) {
   const sourceCode = getSourceCode(context);
   return sourceCode.getAncestors ? sourceCode.getAncestors(node) : context.getAncestors();
@@ -38,6 +42,7 @@ function getText(context) {
 
 module.exports = {
   getAncestors,
+  getFilename,
   getFirstTokens,
   getScope,
   getSourceCode,

lib/util/makeNoMethodSetStateRule.js

@@ -51,14 +51,16 @@ function shouldBeNoop(context, methodName) {
  * @returns {import('eslint').Rule.RuleModule}
  */
 module.exports = function makeNoMethodSetStateRule(methodName, shouldCheckUnsafeCb) {
+  const docs = {
+    description: `Disallow usage of setState in ${methodName}`,
+    category: 'Best Practices',
+    recommended: false,
+    url: docsUrl(mapTitle(methodName)),
+  };
+
   return {
     meta: {
-      docs: {
-        description: `Disallow usage of setState in ${methodName}`,
-        category: 'Best Practices',
-        recommended: false,
-        url: docsUrl(mapTitle(methodName)),
-      },
+      docs,
 
       messages,
 

lib/util/version.js

@@ -11,6 +11,7 @@ const path = require('path');
 const resolve = require('resolve');
 const semver = require('semver');
 const error = require('./error');
+const getFilename = require('./eslint').getFilename;
 
 const ULTIMATE_LATEST_SEMVER = '999.999.999';
 
@@ -28,7 +29,7 @@ function resetDetectedVersion() {
 
 function resolveBasedir(contextOrFilename) {
   if (contextOrFilename) {
-    const filename = typeof contextOrFilename === 'string' ? contextOrFilename : contextOrFilename.getFilename();
+    const filename = typeof contextOrFilename === 'string' ? contextOrFilename : getFilename(contextOrFilename);
     const dirname = path.dirname(filename);
     try {
       if (fs.statSync(filename).isFile()) {

types/eslint-core-augment.d.ts

@@ -0,0 +1,13 @@
+import '@eslint/core';
+
+declare module '@eslint/core' {
+  interface SettingsConfig {
+    react?: {
+      pragma?: string;
+      fragment?: string;
+      createClass?: string;
+    };
+  }
+}
+
+export {};