Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-no-literals: Avoid crashing on valueless boolean props #3823

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

reosarevok
Copy link
Contributor

@reosarevok reosarevok commented Sep 12, 2024

b8217ed removed the node.value check leading to this crashing on any valueless boolean prop such as <Component isWhatever />

This just readds the check.

Fixes #3820

b8217ed removed the node.value check
leading to this crashing on any valueless boolean prop such as
<Component isWhatever />

This just readds the check.
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (a09083b) to head (99e15e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3823      +/-   ##
==========================================
+ Coverage   95.97%   97.66%   +1.68%     
==========================================
  Files         136      133       -3     
  Lines        9929     9917      -12     
  Branches     3677     3678       +1     
==========================================
+ Hits         9529     9685     +156     
+ Misses        400      232     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 99e15e1 into jsx-eslint:master Sep 12, 2024
342 checks passed
@reosarevok reosarevok deleted the patch-1 branch September 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants