[New] forbid-component-props: add allowedForPatterns and disallowedForPatterns options
#3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljharb what do you think? |
ljharb
requested changes
Sep 11, 2024
Comment on lines
+145
to
+147
| allowPatternList: typeof value === 'string' ? [] : value.allowedForPatterns || [], | ||
| disallowList: typeof value === 'string' ? [] : (value.disallowedFor || []), | ||
| disallowPatternList: typeof value === 'string' ? [] : value.disallowedForPatterns || [], |
There was a problem hiding this comment.
Suggested change
| allowPatternList: typeof value === 'string' ? [] : value.allowedForPatterns || [], | |
| disallowList: typeof value === 'string' ? [] : (value.disallowedFor || []), | |
| disallowPatternList: typeof value === 'string' ? [] : value.disallowedForPatterns || [], | |
| allowPatternList: [].concat(value.allowedForPatterns || []), | |
| disallowList: [].concat(value.disallowedFor || []), | |
| disallowPatternList: [].concat(value.disallowedForPatterns || []), |
altho i'm not sure why any of these would be able to be strings - doesn't the schema prevent that?
Comment on lines
+172
to
+174
| function checkIsTagForbiddenByAllowList() { | ||
| return options.allowList.indexOf(tagName) === -1; | ||
| } |
There was a problem hiding this comment.
this seems overkill to make into a function, especially if it's used once. let's just inline it.
Comment on lines
+176
to
+184
| function checkIsTagForbiddenByAllowPatternList() { | ||
| if (options.allowPatternList.length === 0) { | ||
| return true; | ||
| } | ||
|
|
||
| return options.allowPatternList.every( | ||
| (pattern) => !minimatch(tagName, pattern) | ||
| ); | ||
| } |
There was a problem hiding this comment.
kind of same here? i'd rather checkIsTagForbiddenByAllowOptions be mutiline with some early returns.
Comment on lines
+190
to
+206
| function checkIsTagForbiddenByDisallowList() { | ||
| return options.disallowList.indexOf(tagName) !== -1; | ||
| } | ||
|
|
||
| function checkIsTagForbiddenByDisallowPatternList() { | ||
| if (options.disallowPatternList.length === 0) { | ||
| return false; | ||
| } | ||
|
|
||
| return options.disallowPatternList.some( | ||
| (pattern) => minimatch(tagName, pattern) | ||
| ); | ||
| } | ||
|
|
||
| function checkIsTagForbiddenByDisallowOptions() { | ||
| return checkIsTagForbiddenByDisallowList() || checkIsTagForbiddenByDisallowPatternList(); | ||
| } |
There was a problem hiding this comment.
same feedback on these three functions
|
Thanks a lot for the feedback, I will apply the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, issue was described here, but it was closed by another PR (although this PR implements different case).
So, this PR just reimplements
Regeximplementation withglobsas was suggested in one of the comments.