Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unknown-property: add fetchPriority #3697

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 26, 2024

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (36e791d) to head (e880213).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3697   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         133      133           
  Lines        9469     9469           
  Branches     3471     3471           
=======================================
  Hits         9257     9257           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added test coverage

@ljharb ljharb merged commit e880213 into jsx-eslint:master Feb 26, 2024
309 checks passed
@SevereCloud SevereCloud deleted the patch-1 branch February 27, 2024 09:27
@coreyward
Copy link

React is complaining about this:

Screenshot 2024-04-18 at 7 58 29 PM

@ljharb
Copy link
Member

ljharb commented Apr 19, 2024

Sounds like you should file an issue on React then?

@SevereCloud
Copy link
Contributor Author

React is complaining about this:

Screenshot 2024-04-18 at 7 58 29 PM

PR has been merged, but not released

@ljharb
Copy link
Member

ljharb commented Apr 21, 2024

ah, in that case we should detect the react version and only allow this property when react supports it. @SevereCloud can you file a new PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants