Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] forbid-component-props accepts allowedForRegex and disallowedForRegex #3687

Closed
wants to merge 5 commits into from

Conversation

bschlenk
Copy link

@bschlenk bschlenk commented Feb 8, 2024

Fixes #3686

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9f4b2b9) 97.74% compared to head (7723121) 97.73%.

Files Patch % Lines
lib/rules/forbid-component-props.js 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3687      +/-   ##
==========================================
- Coverage   97.74%   97.73%   -0.01%     
==========================================
  Files         132      132              
  Lines        9409     9420      +11     
  Branches     3449     3454       +5     
==========================================
+ Hits         9197     9207      +10     
- Misses        212      213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Feb 8, 2024

PR was a bit premature; regexes in eslint configs are hugely insecure and a CVE farm, and should never exist.

@akulsr0
Copy link
Contributor

akulsr0 commented Jul 18, 2024

This is solved in #3774, can be closed.

@ljharb ljharb closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rule enhancement: allow regex in forbid-component-props allowedFor / disallowedFor
3 participants