Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] jsx-wrap-multilines: add never option to prohibit wrapping parens on multiline JSX #3668

Merged
merged 1 commit into from
Dec 15, 2023
Merged

[New] jsx-wrap-multilines: add never option to prohibit wrapping parens on multiline JSX #3668

merged 1 commit into from
Dec 15, 2023

Conversation

reedws
Copy link
Contributor

@reedws reedws commented Dec 15, 2023

Fixes #1035

First PR here so if I'm missing anything please let me know!
(Also I'm aware this particular option is very controversial, please don't hate me 😇)

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37d8bbe) 97.65% compared to head (b4b7497) 97.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3668   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         132      132           
  Lines        9375     9379    +4     
  Branches     3432     3433    +1     
=======================================
+ Hits         9155     9159    +4     
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style is atrocious, but your PR is good. Thanks!

@ljharb ljharb changed the title never wrap multilines [New] react/jsx-wrap-multilines: add never option to prohibit wrapping parens on multiline JSX Dec 15, 2023
@ljharb
Copy link
Member

ljharb commented Dec 15, 2023

Relates to #1039 as well, i think.

@ljharb ljharb changed the title [New] react/jsx-wrap-multilines: add never option to prohibit wrapping parens on multiline JSX [New] jsx-wrap-multilines: add never option to prohibit wrapping parens on multiline JSX Dec 15, 2023
@ljharb ljharb merged commit b4b7497 into jsx-eslint:master Dec 15, 2023
309 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

"react/jsx-wrap-multilines": "never" option
2 participants