Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-unknown-property: ensure not to report unknown-property in onResize #3662

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

caesar1030
Copy link
Contributor

@caesar1030 caesar1030 commented Dec 3, 2023

Fixes #3594

@caesar1030 caesar1030 changed the title [Fix] no-unknown-property: ensure not to report unknown-property in onResize [Fix] no-unknown-property: ensure not to report unknown-property in onResize Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48318fa) 97.65% compared to head (5aac678) 97.65%.

❗ Current head 5aac678 differs from pull request most recent head b95a059. Consider uploading reports for the commit b95a059 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3662   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         132      132           
  Lines        9375     9375           
  Branches     3432     3432           
=======================================
  Hits         9155     9155           
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Dec 3, 2023

I’m confused; why does this PR have a bunch of unrelated commits?

@caesar1030
Copy link
Contributor Author

@ljharb I'm really, really sorry. Currently, there is a problem due to mishandling of git. Is it possible to delete the pr and upload it again?

@ljharb
Copy link
Member

ljharb commented Dec 3, 2023

Please do not do that; the branch can be rebased and force pushed to fix the PR.

@caesar1030
Copy link
Contributor Author

@ljharb Yes, I will tell you again after editing. I am truly sorry once again for the confusion.

@caesar1030 caesar1030 force-pushed the Issue#3594-fix-resize-event branch 2 times, most recently from 74d2282 to 5aac678 Compare December 3, 2023 16:32
@ljharb ljharb marked this pull request as draft December 3, 2023 17:25
@caesar1030
Copy link
Contributor Author

@ljharb The fix has been completed. Could you please check? Thank you always for your kind answers.

@ljharb ljharb marked this pull request as ready for review December 3, 2023 22:43
@ljharb ljharb force-pushed the Issue#3594-fix-resize-event branch from 5aac678 to b95a059 Compare December 3, 2023 22:43
@ljharb ljharb merged commit b95a059 into jsx-eslint:master Dec 4, 2023
313 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: onResize reported by react/no-unknown-property on video elements
2 participants