Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] no-invalid-html-attribute: add support for apple-touch-startup-image rel attributes in link tags #3638

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[New] no-invalid-html-attribute: add support for apple-touch-startup-image rel attributes in link tags #3638

merged 1 commit into from
Oct 9, 2023

Conversation

thomashockaday
Copy link
Contributor

Currently this attribute fails on the latest version:

“apple-touch-startup-image” is never a valid “rel” attribute value  react/no-invalid-html-attribute

According to the docs the accepted values for this rule come from MDN, and MDN states that this value is non-standard but not disallowed, the same as apple-touch-icon.

If I am incorrect here please let me know.

To test this I've added a generic example as seen in Apple's own documentation as well as a longer example more like something that a PWA asset generator would give you (which is recommended by web.dev).

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #3638 (9da1bb0) into master (d36ca2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3638   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         132      132           
  Lines        9360     9360           
  Branches     3427     3427           
=======================================
  Hits         9140     9140           
  Misses        220      220           
Files Coverage Δ
lib/rules/no-invalid-html-attribute.js 96.57% <ø> (ø)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb changed the title Add support for apple-touch-startup-image rel attributes in link tags [New] no-invalid-html-attribute: add support for apple-touch-startup-image rel attributes in link tags Oct 9, 2023
@ljharb ljharb added the hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it. label Oct 9, 2023
@ljharb ljharb merged commit 9da1bb0 into jsx-eslint:master Oct 9, 2023
284 of 292 checks passed
@ljharb
Copy link
Member

ljharb commented Oct 9, 2023

The failing tests are unrelated to this PR; I'll fix them on master after landing this.

@thomashockaday thomashockaday deleted the feature/add-support-for-apple-touch-startup-image branch October 10, 2023 09:22
@GabrielF9
Copy link

Hey guys, sorry to be bothering, I don't know how the releases works here. Just pinging to know if we have a prevision when this fix will become to a release.

@ljharb
Copy link
Member

ljharb commented Nov 27, 2023

There’s no timeline; it’ll be included in the next release.

@GabrielF9
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest-accepted If you're interested in a free shirt, this PR counts towards it.
Development

Successfully merging this pull request may close these issues.

3 participants