Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] sort-prop-types: ensure sort-prop-types respects noSortAlphabetically #3610

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

caesar1030
Copy link
Contributor

Fixes #3591

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #3610 (3c11201) into master (302925b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
+ Coverage   97.62%   97.63%   +0.01%     
==========================================
  Files         132      132              
  Lines        9288     9289       +1     
  Branches     3394     3395       +1     
==========================================
+ Hits         9067     9069       +2     
+ Misses        221      220       -1     
Impacted Files Coverage Δ
lib/rules/sort-prop-types.js 98.27% <ø> (ø)
lib/util/propTypesSort.js 100.00% <100.00%> (+1.23%) ⬆️

@ljharb
Copy link
Member

ljharb commented Jul 23, 2023

Duplicate of #3609 - which means both must now stay open so I can keep them in sync and land them together.

@ljharb ljharb force-pushed the Issue#3591-fix-sort-props branch from 63e88c1 to 3c11201 Compare July 24, 2023 05:50
@caesar1030
Copy link
Contributor Author

caesar1030 commented Jul 24, 2023

First of all, I really appreciate for the code review.

It's my first time to participate in open source, so I closed the first pr and created a new pr because I didn't seem to have properly kept the commit convention with other people and didn't write the test code properly in the first pr.

Thank you for caring me!

@ljharb
Copy link
Member

ljharb commented Jul 24, 2023

@caesar1030 no problem - in the future, it's best to reuse the PR rather than making a new one (but also, to not make a PR from master/main).

@ljharb ljharb merged commit 3c11201 into jsx-eslint:master Jul 24, 2023
585 checks passed
@caesar1030
Copy link
Contributor Author

@ljharb thank you! I'll be careful not to repeat the same mistake in the next pr :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fixer of sort-prop-types doesn’t respect noSortAlphabetically
2 participants