-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword jsx-no-bind rationale #3581
Conversation
Rewording the performance rationale for jsx-no-bind to clarify that the performance implications are specifically for memoized components.
Codecov Report
@@ Coverage Diff @@
## master #3581 +/- ##
=======================================
Coverage 97.61% 97.62%
=======================================
Files 132 132
Lines 9280 9295 +15
Branches 3391 3400 +9
=======================================
+ Hits 9059 9074 +15
Misses 221 221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on this?
Also, could we maybe add some examples as well to showcase the different kinds of functions that apply?
I've also now updated the "when not to use section" to be consistent with the rationale. Sorry for the multiple micro edits! |
I'm proposing rewording the rationale for jsx-no-bind to:
memo
since I thinkmemo
ised components are probably the most common component with performance impacts from this rule