[Fix] jsx-no-leaked-render: invalid fixes in coerce mode

[akulsr0]

Fixes #3431

[codecov]

Codecov Report

Merging #3511 (438472f) into master (12fe944) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 438472f differs from pull request most recent head f350303. Consider uploading reports for the commit f350303 to get more accurate results

@@           Coverage Diff           @@
##           master    #3511   +/-   ##
=======================================
  Coverage   97.57%   97.58%           
=======================================
  Files         130      130           
  Lines        9213     9221    +8     
  Branches     3342     3348    +6     
=======================================
+ Hits         8990     8998    +8     
  Misses        223      223           

Impacted Files	Coverage Δ
lib/rules/jsx-no-leaked-render.js	98.70% <100.00%> (+0.15%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ljharb]

Thanks!

[ljharb]

@akulsr0 seems like tests are failing

[akulsr0]

@ljharb I am not sure why tests are failing here, I have tried with different node versions in local, its passing all test cases.

[ljharb]

The failures are in eslint < 5.

[ljharb]

I’m not sure why the output is different in eslint 3 and 4, but we may have to make the test output condition on eslint version.

[akulsr0]

Do we have any example case where output is based on eslint version?

[ljharb]

@akulsr0 mostly examples of test cases that are entirely skipped, but

eslint-plugin-react/tests/lib/rules/sort-prop-types.js

Lines 505 to 540 in 12fe944

	semver.satisfies(eslintPkg.version, '> 3') ? {
	code: `
	var First = createReactClass({
	propTypes: {
	/* z */
	z: PropTypes.string,
	/* a */
	a: PropTypes.any
	},
	render: function() {
	return <div />;
	}
	});
	`,
	output: `
	var First = createReactClass({
	propTypes: {
	/* a */
	a: PropTypes.any,
	/* z */
	z: PropTypes.string
	},
	render: function() {
	return <div />;
	}
	});
	`,
	errors: [
	{
	messageId: 'propsNotSorted',
	line: 7,
	column: 13,
	type: 'Property',
	},
	],
	} : [],

should hopefully be enough for you to figure out how to adapt it?

[ljharb]

I tweaked your changes so the test cases still run in eslint 3, and it exposed a bug, which i then fixed. This should hopefully be good to go once tests pass.