-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3488
Merged
ljharb
merged 1 commit into
jsx-eslint:master
from
himanshu007-creator:himanshu-fix-jsx
Nov 21, 2022
Merged
jsx-no-leaked-render: Don't report errors on empty strings if React >= v18 #3488
ljharb
merged 1 commit into
jsx-eslint:master
from
himanshu007-creator:himanshu-fix-jsx
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3488 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 129 129
Lines 9209 9212 +3
Branches 3341 3342 +1
=======================================
+ Hits 8986 8989 +3
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
requested changes
Nov 16, 2022
ljharb
force-pushed
the
master
branch
4 times, most recently
from
November 18, 2022 17:19
069314a
to
181c68f
Compare
ljharb
requested changes
Nov 18, 2022
ljharb
force-pushed
the
himanshu-fix-jsx
branch
2 times, most recently
from
November 21, 2022 00:54
5668f9d
to
c02d4e3
Compare
ljharb
approved these changes
Nov 21, 2022
This was referenced May 24, 2024
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3479