-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] sort-prop-types
: avoid crash when autofixing
#3471
[Fix] sort-prop-types
: avoid crash when autofixing
#3471
Conversation
59af733
to
865ed16
Compare
27309f1
to
b40366d
Compare
@ROSSROSALES i think this needs to be rebased on latest, and i'm not sure of the best way to do it. Can you give it a try? |
I'll give it a try to rebase on latest |
b40366d
to
e6a9c89
Compare
Codecov Report
@@ Coverage Diff @@
## master #3471 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 129 129
Lines 9212 9214 +2
Branches 3342 3341 -1
=======================================
+ Hits 8989 8991 +2
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
069314a
to
181c68f
Compare
e6a9c89
to
1ee5db8
Compare
8799c44
to
668d54f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty good if tests pass.
668d54f
to
4243dcc
Compare
sort-prop-types
: avoid crash when autofixing
4243dcc
to
cc9578c
Compare
Fixes #3470
Now rule respects multiple comments before and after prop.
Fixes issue of no comments before and after prop not being considered during parsing.