-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-unknown-property
add more <video>
attributes, onMouseMoveCapture
and changes to rule documentation
#3390
no-unknown-property
add more <video>
attributes, onMouseMoveCapture
and changes to rule documentation
#3390
Conversation
…ecific attribute
Codecov Report
@@ Coverage Diff @@
## master #3390 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 123 123
Lines 8957 8957
Branches 3269 3269
=======================================
Hits 8741 8741
Misses 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…rties with libraries that add props
no-unknown-property
add more <video>
attributesno-unknown-property
add more <video>
attributes, onMouseMoveCapture
and changes to rule documentation
0e72eb6
to
900d6a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Many of the video attrs also work on audio, so i added those too.
Looks like it's |
How about |
@wereHamster see #3398. |
This PR adds:
autoPictureInPicture
,controls
,controlList
,disablePictureInPicture
,disableRemotePlayback
,loop
,muted
,poster
,preload
and allows them only on<video>
element<line>
,<mask>
and<use>
to havefill
propertyonError
property on<link>
and<source>
elementsonLoad
property on<link>
elementdata-*
propertiesallowFullscreen
to case ignored propertiesno-unknown-property
rule documentation about ignored properties, when using libraries that pass information with some new props (likecss
prop when usingemotion
)