-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] no-unknown-property
add properties onToggle, fill, as, pointer events, media events and touch events
#3385
[Fix] no-unknown-property
add properties onToggle, fill, as, pointer events, media events and touch events
#3385
Conversation
… and pointer events
Codecov Report
@@ Coverage Diff @@
## master #3385 +/- ##
==========================================
+ Coverage 97.57% 97.58% +0.01%
==========================================
Files 123 123
Lines 8954 8957 +3
Branches 3268 3269 +1
==========================================
+ Hits 8737 8741 +4
+ Misses 217 216 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I made the suggestions you had ✔️ |
no-unknown-property
add properties onToggle, fill, as and pointer events
My project started emitting eslint errors when using touch events. I don't see them events listed in this change. Could/should they also be included? https://reactjs.org/docs/events.html#touch-events
|
no-unknown-property
add properties onToggle, fill, as and pointer eventsno-unknown-property
add properties onToggle, fill, as, pointer events, media events and touch events
Thanks for pointing them out @jdufresne 👍 |
… iframes have `scrolling`; video has `playsInline`
d452ea7
to
a2ec87d
Compare
Closes #3384