Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: avoid a crash when function has no props param #3350

Merged
merged 1 commit into from
Aug 4, 2022
Merged

[Fix]: avoid a crash when function has no props param #3350

merged 1 commit into from
Aug 4, 2022

Conversation

noahnu
Copy link
Contributor

@noahnu noahnu commented Aug 4, 2022

See added test case.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3350 (7302a2a) into master (9139830) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3350   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         123      123           
  Lines        8788     8790    +2     
  Branches     3190     3191    +1     
=======================================
+ Hits         8587     8589    +2     
  Misses        201      201           
Impacted Files Coverage Δ
lib/rules/require-default-props.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@ljharb ljharb merged commit 7302a2a into jsx-eslint:master Aug 4, 2022
@noahnu noahnu deleted the handle_empty_props branch August 4, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants