Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] jsx-no-useless-fragment: add more examples of correct code #3349

Merged
merged 1 commit into from
Aug 4, 2022
Merged

[Docs] jsx-no-useless-fragment: add more examples of correct code #3349

merged 1 commit into from
Aug 4, 2022

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Aug 4, 2022

Hey @ljharb ! 👋

Just a quick PR to:

  1. Add some simpler examples of how to resolve the react/jsx-no-useless-fragment problems when they appear (there are not as many simple examples of just removing the fragment when there's a single child)
  2. Add an example with an embedded expression and ternary

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3349 (9ffd3b5) into master (7302a2a) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9ffd3b5 differs from pull request most recent head ab72e48. Consider uploading reports for the commit ab72e48 to get more accurate results

@@            Coverage Diff             @@
##           master    #3349      +/-   ##
==========================================
- Coverage   97.71%   97.71%   -0.01%     
==========================================
  Files         123      123              
  Lines        8790     8788       -2     
  Branches     3191     3190       -1     
==========================================
- Hits         8589     8587       -2     
  Misses        201      201              
Impacted Files Coverage Δ
lib/rules/require-default-props.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@karlhorky karlhorky changed the title Add more common, simple examples of correct code Add common, simple correct examples, add ternary example Aug 4, 2022
@ljharb ljharb changed the title Add common, simple correct examples, add ternary example [Docs] jsx-no-useless-fragment: add more examples of correct code Aug 4, 2022
@ljharb ljharb merged commit ab72e48 into jsx-eslint:master Aug 4, 2022
@karlhorky
Copy link
Contributor Author

Thanks for the review and merge!

@karlhorky karlhorky deleted the patch-1 branch August 5, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants