-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] False negative when rel attribute assigned using ternary #3332
Conversation
…igned using ConditionalExpression
Codecov Report
@@ Coverage Diff @@
## master #3332 +/- ##
==========================================
+ Coverage 97.49% 97.76% +0.27%
==========================================
Files 123 123
Lines 8861 8833 -28
Branches 3238 3219 -19
==========================================
- Hits 8639 8636 -3
+ Misses 222 197 -25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@V2dha i've rebased this, and there's still 48 test failures - all things that expect an error but now get none. I think the some/every change may be related. |
Fixes #2962