Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] jsx-no-target-blank: Fix link to link-type-noreferrer #3319

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

Luccasoli
Copy link
Contributor

@Luccasoli Luccasoli commented Jul 4, 2022

I updated the link to the "noreferrer" explanation instead of a link to the "noopener" explanation, since the paragraph where this link is located only talks about the "noreferrer".

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #3319 (5cf46ca) into master (23121e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3319   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         123      123           
  Lines        8873     8873           
  Branches     3244     3244           
=======================================
  Hits         8655     8655           
  Misses        218      218           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ljharb
Copy link
Member

ljharb commented Jul 5, 2022

@Luccasoli
Copy link
Contributor Author

Hi @ljharb, what's up?

Sorry for the PR without context..., I suggested this change because this paragraph I edited talks about the "noreferrer" configuration instead of "noopener", so I thought this link would be more appropriate, what do you think?

@ljharb
Copy link
Member

ljharb commented Jul 5, 2022

Let's include both links.

@ljharb ljharb changed the title Fix link to link-type-noreferrer [Docs] jsx-no-target-blank: Fix link to link-type-noreferrer Aug 13, 2022
@ljharb ljharb merged commit 5cf46ca into jsx-eslint:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants