-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] jsx-indent
, jsx-one-expression-per-line
: add passing test cases
#3314
Conversation
Passing test cases for issue #2318 |
What happened here? Can you please restore the branch and reopen the PR? |
I apologize, I think I pushed to master branch before my forked repo. I noticed more failing testing cases that is also why I deleted the branch but I will restore the branch and reopen the PR. |
I think we should add the exact test code from the issue: <Layout>
<SEO title="Home" />
<h1>{"Hi people"}<button/></h1>
<p>Welcome to your new Gatsby site.</p>
<p>Now go build something great.</p>
<h1>Hi people<button/></h1>
<div style={{ maxWidth: `300px`, marginBottom: `1.45rem` }}>
<Image />
</div><Link to="/page-2/">Go to page 2</Link>
</Layout> |
Sorry if I ask a lot of questions, but just to clarify:
Thank you for the guidance! |
Yep, exactly! I'd expect the same test input to be added to both rules' test files, each covering the autofix output of the relevant rule. |
Codecov Report
@@ Coverage Diff @@
## master #3314 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 123 123
Lines 8777 8777
Branches 3184 3184
=======================================
Hits 8576 8576
Misses 201 201 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
414159e
to
437fe3c
Compare
jsx-indent
, jsx-one-expression-per-line
: add passing test cases
Increased test coverage for jsx-one-expression-per-line.js
Fixes #2318