Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove david-dm badge from README #3262

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

ddzz
Copy link
Contributor

@ddzz ddzz commented Apr 2, 2022

The david-dm service is no longer available, so this badge can be removed from the README.

@ljharb
Copy link
Member

ljharb commented Apr 2, 2022

It’s not working right now, but that’s not the same thing as no longer available. Can you elaborate?

@ddzz
Copy link
Contributor Author

ddzz commented Apr 3, 2022

It’s not working right now, but that’s not the same thing as no longer available. Can you elaborate?

It's been down for months, and there's no indication that the service is coming back. See alanshaw/david#182

@ddzz ddzz closed this Jul 14, 2022
@ddzz ddzz deleted the cleanup-readme branch July 14, 2022 16:26
@ljharb
Copy link
Member

ljharb commented Jul 14, 2022

It'd still be nice to keep this open, once we hear back from Alan.

@ddzz ddzz restored the cleanup-readme branch July 14, 2022 16:30
@ddzz ddzz reopened this Jul 14, 2022
@ddzz
Copy link
Contributor Author

ddzz commented Jul 14, 2022

It'd still be nice to keep this open, once we hear back from Alan.

👍 I just reopened it. I'll try to fix the merge conflict this evening.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@0cc979d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6e868b1 differs from pull request most recent head c28ae9e. Consider uploading reports for the commit c28ae9e to get more accurate results

@@            Coverage Diff            @@
##             master    #3262   +/-   ##
=========================================
  Coverage          ?   97.71%           
=========================================
  Files             ?      123           
  Lines             ?     8788           
  Branches          ?     3190           
=========================================
  Hits              ?     8587           
  Misses            ?      201           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can always re-add if the service comes back.

@ljharb ljharb merged commit c28ae9e into jsx-eslint:master Aug 5, 2022
@ddzz ddzz deleted the cleanup-readme branch August 5, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants