Improve no-unstable-nested-components error message and catch React.memo() #3247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3231.
The bugfix itself is just one line since
React.memo
wrappers are already being detected as components; this plugin just wasn't searching forCallExpression
s.I've also updated the error message to be more specific about the recommended fix. Technically this can also be fixed by calling the function directly (
renderComponent(props)
vs<Component {...props} />
) but I'm not sure if we want to squeeze that into the error message.Memoizing with
useCallback()
is not generally safe since the returned function isn't guaranteed to be stable, even if the deps are empty. I have a branch that can detect this, but that probably has other consequences so I'll leave it to a separate PR.