Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev Deps] update eslint-remote-tester-run-action #3120

Merged

Conversation

AriPerkkio
Copy link
Contributor

Adds support for ESLint v8. Works with ESLint v7 too.

Example run: https://github.com/AriPerkkio/eslint-plugin-react/actions/runs/1415490892. The no-invalid-html-attribute rule crashed couple of times there.

@AriPerkkio
Copy link
Contributor Author

AriPerkkio commented Nov 3, 2021

Also one thing worth to mention:

The eslint-remote-tester-run-action@v2 is using Github Docker Action with Node 14. For some reason npm link doesn't work if workflow is using node 14, but node 16 works.

Basically this kind of change is required in order to have npm link working between the workflow and Github Docker Action.

      - uses: actions/setup-node@v1
        with:
-         node-version: 14
+         node-version: 16

@ljharb any ideas why node@14 package links do not pass to Docker containers, even if both host and container are using the same version? Node version of Github Docker action doesn't matter as long as the workflow is running Node 16.

The current workflow here is working OK since ljharb/actions/node/install@main ends up with Node 16:

https://github.com/yannickcr/eslint-plugin-react/blob/d62ab20baa6251cf29933f5633453984bb749c13/.github/workflows/smoke-test.yml#L14-L18

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #3120 (9fd9856) into master (bf08998) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3120   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         119      119           
  Lines        8044     8044           
  Branches     2867     2867           
=======================================
  Hits         7840     7840           
  Misses        204      204           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf08998...9fd9856. Read the comment docs.

@ljharb
Copy link
Member

ljharb commented Nov 3, 2021

My guess is that npm 6 has a bug that npm 7 fixes. Are you installing the latest npm version always? If not, try that :-)

@AriPerkkio
Copy link
Contributor Author

Ah yes it seems there is a bug in npm 6. Updating npm in the workflow/host works.
After debugging this for too long it's great to find a root cause. Thanks! 👍 🎉

Container / action npm@6 and node14:

  • Host / workflow npm@6 and node14. npm link fails with Cannot find module 'eslint-plugin-react'
  • Host / workflow npm@7 and node14. npm link works.
  • Host / workflow npm@8 and node14. npm link works.

@ljharb ljharb force-pushed the deps/eslint-remote-tester-run-action-v2 branch from 5da788d to 9fd9856 Compare November 3, 2021 18:09
@ljharb ljharb changed the title [Dev Deps]: Update eslint-remote-tester-run-action [Dev Deps] update eslint-remote-tester-run-action Nov 3, 2021
@ljharb ljharb merged commit 9fd9856 into jsx-eslint:master Nov 3, 2021
@AriPerkkio AriPerkkio deleted the deps/eslint-remote-tester-run-action-v2 branch November 4, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants