[New] jsx-indent-props: add ignoreTernaryOperator option
#2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 6, 2020
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Let's pick an option name where absence and false are the same.
How about, ignoreTernaryOperator that defaults to false?
docs/rules/jsx-indent-props.md
Outdated
| It takes an option as the second parameter which can either be the indent mode or an object to define further settings. | ||
| The indent mode can be `"tab"` for tab-based indentation, a positive number for space indentations or `"first"` for aligning the first prop for each line with the tag's first prop. | ||
| Note that using the `"first"` option allows very inconsistent indentation unless you also enable a rule that enforces the position of the first prop. | ||
| If second parameter is an object, it can be used to specify the indent mode as well as if the indent level is increased by a `?` operator `:` (default is `true`). |
Member
There was a problem hiding this comment.
Suggested change
| If second parameter is an object, it can be used to specify the indent mode as well as if the indent level is increased by a `?` operator `:` (default is `true`). | |
| If the second parameter is an object, it can be used to specify the indent mode as well as if the indent level is increased by a `?`or `:` operator (default is `true`). |
Comment on lines
157
to
172
| code: [ | ||
| '{this.props.test', | ||
| ' ? <span', | ||
| ' className="value"', | ||
| ' some={{aaa}}', | ||
| ' />', | ||
| ' : null}' | ||
| ].join('\n'), |
Member
There was a problem hiding this comment.
Suggested change
| code: [ | |
| '{this.props.test', | |
| ' ? <span', | |
| ' className="value"', | |
| ' some={{aaa}}', | |
| ' />', | |
| ' : null}' | |
| ].join('\n'), | |
| code: [ | |
| '{this.props.test', | |
| ' ? <span', | |
| ' className="value"', | |
| ' some={{aaa}}', | |
| ' />', | |
| ' : null}' | |
| ].join('\n'), |
i think that with increaseByTernaryOperator set to true, this should be what's valid, no?
Author
Good idea, I've changed it that way and adjusted documentation and tests. |
ljharb
changed the title
increaseByTernaryOperator option for jsx-indent-propsjsx-indent-props: add ignoreTernaryOperator option
ljharb
approved these changes
Dec 23, 2020
This was referenced Mar 10, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.