Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] add iframe-missing-sandbox rule (migrate rule from TSLint) #2753

Merged
merged 1 commit into from
Feb 2, 2022
Merged

[New] add iframe-missing-sandbox rule (migrate rule from TSLint) #2753

merged 1 commit into from
Feb 2, 2022

Conversation

tosmolka
Copy link
Contributor

@tosmolka tosmolka commented Aug 13, 2020 •
edited by ljharb
Loading

Fixes #2754

@tosmolka @ljharb
[New] add iframe-missing-sandbox rule
d9ccfe4 
Co-authored-by: Tobias Smolka <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
@tosmolka tosmolka mentioned this pull request Aug 13, 2020
Closed
@tosmolka tosmolka changed the title First attempt on iframe-missing-sandbox rule Migrate rule from TSLint: react-iframe-missing-sandbox #2754 Aug 13, 2020
@tosmolka tosmolka changed the title Migrate rule from TSLint: react-iframe-missing-sandbox #2754 Migrate rule from TSLint: react-iframe-missing-sandbox Aug 13, 2020
ljharb
ljharb approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this, and updated it to also cover React.createElement.

I also updated the list of values, and the URL to MDN (w3schools is harmful)

docs/rules/iframe-missing-sandbox.md Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the feature/iframe-missing-sandbox branch from 30a2985 to d9ccfe4 Compare February 2, 2022 00:48
@ljharb ljharb added the new rule label Feb 2, 2022
@ljharb ljharb changed the title Migrate rule from TSLint: react-iframe-missing-sandbox [New] add iframe-missing-sandbox rule (migrate rule from TSLint) Feb 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #2753 (d9ccfe4) into master (36482a3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
+ Coverage   97.53%   97.54%   +0.01%     
==========================================
  Files         120      121       +1     
  Lines        8302     8359      +57     
  Branches     2988     3009      +21     
==========================================
+ Hits         8097     8154      +57     
  Misses        205      205
Impacted Files Coverage Δ
index.js 100.00% <ø> (ø)
lib/rules/iframe-missing-sandbox.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36482a3...d9ccfe4. Read the comment docs.

@ljharb ljharb merged commit d9ccfe4 into jsx-eslint:master Feb 2, 2022
@tosmolka
Copy link
Contributor Author

tosmolka commented Feb 2, 2022

Thanks @ljharb , I totally forgot about this one. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
new rule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate rule from TSLint: react-iframe-missing-sandbox
3 participants
@tosmolka @codecov-commenter @ljharb