Issue #1632 - jsx-sort-props: reservedFirst conflicts with callbacksLast #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icts with callbacksLast See jsx-eslint#1632.
|
Thanks, this looks great! |
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 121 121
Lines 8391 8391
Branches 3018 3018
=======================================
Hits 8187 8187
Misses 204 204 Continue to review full report at Codecov.
|
|
@kolpax so sorry this slipped through the cracks! The tests are failing, but oddly, only in eslint 7. Additionally, when I comment out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated unit test with failing case for callbacksLast not working when used in combination with reservedFirst. (First ever pull request - tell me if I did something wrong!)