Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-sort-default-props misnamed #1834

Open
webOS101 opened this issue Jun 19, 2018 · 3 comments
Open

jsx-sort-default-props misnamed #1834

webOS101 opened this issue Jun 19, 2018 · 3 comments

Comments

@webOS101
Copy link
Contributor

Why does this rule have 'jsx' in the name? It is not a jsx related rule. Can this be renamed to be more consistent with the other rules?
@ljharb
Copy link
Member

ljharb commented Jun 19, 2018

The first step would be a semver-minor change, adding in sort-default-props without removing jsx-sort-default-props (but deprecating it).

Later, when it's time for a semver-major, we could then remove the jsx- one.

@alexzherdev
Copy link
Contributor

I'm working on the first part of it now. Do we also want to copy the tests? If there is a bug in the rule before next semver-major, will we be fixing it in two places and adding tests to two files then?

@ljharb
Copy link
Member

ljharb commented Jun 29, 2018

Yes, and yes.

alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jun 29, 2018
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
4dc8c4d 
Pt. 1 of jsx-eslint#1834
@alexzherdev alexzherdev mentioned this issue Jun 29, 2018
Merged
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jun 30, 2018
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
e212430 
Pt. 1 of jsx-eslint#1834
Also fixes jsx-eslint#1817
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jul 3, 2018
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
8d775a6 
Pt. 1 of jsx-eslint#1834
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jul 24, 2018
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
32cb939 
Pt. 1 of jsx-eslint#1834
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jan 12, 2019
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
c7fa863 
Pt. 1 of jsx-eslint#1834
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jul 6, 2019
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
fa02359 
Pt. 1 of jsx-eslint#1834
alexzherdev added a commit to alexzherdev/eslint-plugin-react that referenced this issue Jul 6, 2019
@alexzherdev
Add sort-default-props and deprecate jsx-sort-default-props
bbb029b 
Pt. 1 of jsx-eslint#1834
ljharb pushed a commit to alexzherdev/eslint-plugin-react that referenced this issue Sep 30, 2022
@alexzherdev @ljharb
[New] add sort-default-props and deprecate jsx-sort-default-props
61c369c 
Pt. 1 of jsx-eslint#1834
ljharb pushed a commit to alexzherdev/eslint-plugin-react that referenced this issue Sep 30, 2022
@alexzherdev @ljharb
[New] add sort-default-props and deprecate jsx-sort-default-props
323f63f 
Part 1 of jsx-eslint#1834
ljharb pushed a commit to alexzherdev/eslint-plugin-react that referenced this issue Oct 10, 2022
@alexzherdev @ljharb
[New] add sort-default-props and deprecate jsx-sort-default-props
feae3bc 
Part 1 of jsx-eslint#1834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @alexzherdev @webOS101