Fix wrong prop-types detection (fixes #255)

jsx-eslint · Oct 18, 2015 · fe1ef9b · fe1ef9b
1 parent 3cc654d
commit fe1ef9b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -31,7 +31,10 @@ module.exports = function(context) {
    * @returns {Boolean} True if we are using a prop, false if not.
    */
   function isPropTypesUsage(node) {
-    var isClassUsage = node.object.type === 'ThisExpression' && node.property.name === 'props';
+    var isClassUsage = (
+      componentUtil.getNode(context, node) &&
+      node.object.type === 'ThisExpression' && node.property.name === 'props'
+    );
     var isStatelessFunctionUsage = node.object.name === 'props';
     return isClassUsage || isStatelessFunctionUsage;
   }

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -795,6 +795,16 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      // Should not be detected as a component
+      code: [
+        'HelloJohn.prototype.render = function() {',
+        '  return React.createElement(Hello, {',
+        '    name: this.props.firstname',
+        '  });',
+        '};'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],