[Fix] jsx-sort-props: avoid a crash

Fixes #3371.
jsx-eslint · Aug 30, 2022 · dc62a8c · dc62a8c
1 parent 3d58253
commit dc62a8c
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/rules/jsx-sort-props.js b/lib/rules/jsx-sort-props.js
@@ -181,9 +181,11 @@ function getGroupsOfSortableAttributes(attributes, context) {
             addtoSortableAttributeGroups(attribute);
             i += 1;
           } else if (attributeline === commentline) {
-            if (firstComment.type === 'Block') {
+            if (firstComment.type === 'Block' && nextAttribute) {
               attributeMap.set(attribute, [nextAttribute.range[1], true]);
               i += 1;
+            } else if (firstComment.type === 'Block') {
+              attributeMap.set(attribute, [firstComment.range[1], true]);
             } else {
               attributeMap.set(attribute, [firstComment.range[1], false]);
             }

diff --git a/tests/lib/rules/jsx-sort-props.js b/tests/lib/rules/jsx-sort-props.js
@@ -1047,6 +1047,32 @@ ruleTester.run('jsx-sort-props', rule, {
           line: 2,
         },
       ],
+    } : [],
+    semver.satisfies(eslintPkg.version, '> 3') ? {
+      code: `
+        <ReactJson src={rowResult} name="data" collapsed={4} collapseStringsAfterLength={60} onEdit={onEdit} /* onDelete={onEdit} */ />
+      `,
+      output: `
+        <ReactJson collapseStringsAfterLength={60} collapsed={4} name="data" src={rowResult} onEdit={onEdit} /* onDelete={onEdit} */ />
+      `,
+      errors: [
+        {
+          messageId: 'sortPropsByAlpha',
+          line: 2,
+        },
+        {
+          messageId: 'sortPropsByAlpha',
+          line: 2,
+        },
+        {
+          messageId: 'sortPropsByAlpha',
+          line: 2,
+        },
+        {
+          messageId: 'sortPropsByAlpha',
+          line: 2,
+        },
+      ],
     } : []
   )),
 });