[Fix] jsx-curly-brace-presence: avoid autofixing attributes with do…

…uble quotes to a double quoted attribute Fixes #3814
jsx-eslint · Sep 3, 2024 · cf868f2 · cf868f2
1 parent 25ae093
commit cf868f2
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,10 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 ### Added
 * [`no-string-refs`]: allow this.refs in > 18.3.0 ([#3807][] @henryqdineen)
 
+### Fixed
+* [`jsx-curly-brace-presence`]: avoid autofixing attributes with double quotes to a double quoted attribute ([#3814][] @ljharb)
+
+[#3814]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3814
 [#3807]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3807
 
 ## [7.35.1] - 2024.09.02

diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -199,10 +199,14 @@ module.exports = {
             const parentType = JSXExpressionNode.parent.type;
 
             if (parentType === 'JSXAttribute') {
-              textToReplace = `"${expressionType === 'TemplateLiteral'
-                ? expression.quasis[0].value.raw
-                : expression.raw.slice(1, -1)
-              }"`;
+              if (expressionType !== 'TemplateLiteral' && /["]/.test(expression.raw.slice(1, -1))) {
+                textToReplace = expression.raw;
+              } else {
+                textToReplace = `"${expressionType === 'TemplateLiteral'
+                  ? expression.quasis[0].value.raw
+                  : expression.raw.slice(1, -1)
+                }"`;
+              }
             } else if (jsxUtil.isJSX(expression)) {
               textToReplace = getText(context, expression);
             } else {

diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js
@@ -945,5 +945,15 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
       output: `<Foo bar="'" />`,
       errors: [{ messageId: 'unnecessaryCurly' }],
     },
+    {
+      code: `
+        <Foo help={'The maximum time range for searches. (i.e. "P30D" for 30 days, "PT24H" for 24 hours)'} />
+      `,
+      options: ['never'],
+      output: `
+        <Foo help='The maximum time range for searches. (i.e. "P30D" for 30 days, "PT24H" for 24 hours)' />
+      `,
+      errors: [{ messageId: 'unnecessaryCurly' }],
+    }
   )),
 });