[Fix] display-name: fix false positive for assignment of function ret…

…urning null
jsx-eslint · Jul 12, 2022 · 9a40514 · 9a40514
1 parent f7fe38f
commit 9a40514
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -508,6 +508,15 @@ function componentRule(rule, context) {
           return undefined;
         }
 
+        // case: any = () => { return => null }
+        // case: any = () => null
+        if (node.parent.type === 'AssignmentExpression' && !isPropertyAssignment && utils.isReturningJSXOrNull(node)) {
+          if (isFirstLetterCapitalized(node.parent.left.name)) {
+            return node;
+          }
+          return undefined;
+        }
+
         // for case abc = { [someobject.somekey]: props => { ... return not-jsx } }
         if (node.parent && node.parent.key && node.parent.key.type === 'MemberExpression' && !utils.isReturningJSX(node) && !utils.isReturningOnlyNull(node)) {
           return undefined;

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -588,6 +588,15 @@ ruleTester.run('display-name', rule, {
         }
       `,
     },
+    {
+      // issue #3329
+      code: `
+        let demo = null;
+        demo = (a) => {
+          if (a == null) return null;
+          return f(a);
+        };`,
+    },
     {
       // issue #3303
       code: `